Skip to content

Test for proxy.config.http.connect_attempts_timeout #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
d2r merged 1 commit into from
Aug 3, 2018
Merged

Test for proxy.config.http.connect_attempts_timeout #4053

d2r merged 1 commit into from
Aug 3, 2018

Conversation

@x-jesse-zhang
Copy link
Contributor

@x-jesse-zhang x-jesse-zhang commented Aug 1, 2018 •
edited
Loading

Needs fix from #4028 to be merged in first before this test can pass AuTest

@shinrich shinrich added this to the 9.0.0 milestone Aug 2, 2018
duke8253
duke8253 previously approved these changes Aug 2, 2018
View reviewed changes
@duke8253
Copy link
Contributor

duke8253 commented Aug 3, 2018

[approve ci autest]

d2r
d2r previously requested changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@d2r d2r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license header.

@d2r d2r dismissed their stale review August 3, 2018 20:32

Review comment addressed

d2r
d2r approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@d2r d2r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test seems fine. Waiting for autest to confirm it passes now before merging. @duke8253 Assuming you are OK with this since you approved earlier.

@d2r d2r merged commit d378b6b into apache:master Aug 3, 2018
@bryancall bryancall modified the milestones: 9.0.0, 8.1.0 Mar 27, 2019
@bryancall
Copy link
Contributor

bryancall commented Mar 27, 2019

Cherry picked to 8.1.0

@zwoop zwoop modified the milestones: 8.1.0, 8.1.0-nogo Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d2r d2r d2r approved these changes

@duke8253 duke8253 duke8253 left review comments

Assignees

@x-jesse-zhang x-jesse-zhang

Labels

Network Tests

Projects

None yet

Milestone

8.1.0-nogo

Development

Successfully merging this pull request may close these issues.

6 participants

@x-jesse-zhang @duke8253 @bryancall @d2r @zwoop @shinrich